feat(i18n): Branch protection improvements

- adds a header to indicate creating a new rule
  - test that header is different between new and edit form
- consistently avoids colons in the form
- excludes some accessibility checks that require a global solution for
  forms

tests/e2e/repo-settings.test.e2e.js

@@ -31,6 +31,18 @@ test('repo branch protection settings', async ({browser}, workerInfo) => {
   const response = await page.goto('/user2/repo1/settings/branches/edit');
   await expect(response?.status()).toBe(200);
 
-  // not yet accessible :(
-  // await validate_form({page}, 'fieldset');
+  await validate_form({page}, 'fieldset');
+
+  // verify header is new
+  await expect(page.locator('h4')).toContainText('new');
+  await page.locator('input[name="rule_name"]').fill('testrule');
+  await page.getByText('Save rule').click();
+  // verify header is in edit mode
+  await page.waitForLoadState('networkidle');
+  await page.getByText('Edit').click();
+  await expect(page.locator('h4')).toContainText('Protection rules for branch');
+  // delete the rule for the next test
+  await page.goBack();
+  await page.getByText('Delete rule').click();
+  await page.getByText('Yes').click();
 });

tests/e2e/shared/forms.js

@@ -4,9 +4,13 @@ import AxeBuilder from '@axe-core/playwright';
 export async function validate_form({page}, scope) {
   scope ??= 'form';
   const accessibilityScanResults = await new AxeBuilder({page})
+    // disable checking for link style - should be fixed, but not now
+    .disableRules('link-in-text-block')
     .include(scope)
     // exclude automated tooltips from accessibility scan, remove when fixed
     .exclude('span[data-tooltip-content')
+    // exclude weird non-semantic HTML disabled content
+    .exclude('.disabled')
     .analyze();
   expect(accessibilityScanResults.violations).toEqual([]);
 
@@ -17,4 +21,10 @@ export async function validate_form({page}, scope) {
     await expect(b).toHaveCSS('margin-top', '0px');
     await expect(b).toHaveCSS('vertical-align', 'baseline');
   }
+  // assert no (trailing) colon is used in labels
+  // might be necessary to adjust in case colons are strictly necessary in help text
+  for (const l of await page.locator('label').all()) {
+    const str = await l.textContent();
+    await expect(str.split('\n')[0]).not.toContain(':');
+  }
 }