finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix cache-control header clearing comment text when editing issue (#22604)

Browse source 
The `no-store` cache control added in #20432 is causing form input to be
cleared unnecessarily on page reload. Instead use
`max-age=0,private,must-revalidate` which avoids this.

This was particularly a problem when typing a long comment for an issue
and then for example changing the label. The page would be reloaded and
lose the unsubmitted comment.

Fixes #22603
This commit is contained in:
Brecht Van Lommel 2023-02-01 22:28:06 +01:00 committed by GitHub
parent b6b8feb3de
commit 1e0e79dcbf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/httpcache/httpcache.go
View file

@ -21,12 +21,12 @@ func AddCacheControlToHeader(h http.Header, maxAge time.Duration, additionalDire
if setting.IsProd { if setting.IsProd {
if maxAge == 0 { if maxAge == 0 {
directives = append(directives, "no-store") directives = append(directives, "max-age=0", "private", "must-revalidate")
} else { } else {
directives = append(directives, "private", "max-age="+strconv.Itoa(int(maxAge.Seconds()))) directives = append(directives, "private", "max-age="+strconv.Itoa(int(maxAge.Seconds())))
} }
} else { } else {
directives = append(directives, "no-store") directives = append(directives, "max-age=0", "private", "must-revalidate")
// to remind users they are using non-prod setting. // to remind users they are using non-prod setting.
h.Add("X-Gitea-Debug", "RUN_MODE="+setting.RunMode) h.Add("X-Gitea-Debug", "RUN_MODE="+setting.RunMode)