Improve valid user name check (#20136)
Close https://github.com/go-gitea/gitea/issues/21640 Before: Gitea can create users like ".xxx" or "x..y", which is not ideal, it's already a consensus that dot filenames have special meanings, and `a..b` is a confusing name when doing cross repo compare. After: stricter Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: delvh <dev.lh@web.de>
This commit is contained in:
parent
4c6b4a67d9
commit
2900dc90a7
12 changed files with 95 additions and 14 deletions
|
@ -53,6 +53,22 @@ func TestRenameInvalidUsername(t *testing.T) {
|
|||
"%00",
|
||||
"thisHas ASpace",
|
||||
"p<A>tho>lo<gical",
|
||||
".",
|
||||
"..",
|
||||
".well-known",
|
||||
".abc",
|
||||
"abc.",
|
||||
"a..bc",
|
||||
"a...bc",
|
||||
"a.-bc",
|
||||
"a._bc",
|
||||
"a_-bc",
|
||||
"a/bc",
|
||||
"☁️",
|
||||
"-",
|
||||
"--diff",
|
||||
"-im-here",
|
||||
"a space",
|
||||
}
|
||||
|
||||
session := loginUser(t, "user2")
|
||||
|
@ -68,7 +84,7 @@ func TestRenameInvalidUsername(t *testing.T) {
|
|||
htmlDoc := NewHTMLParser(t, resp.Body)
|
||||
assert.Contains(t,
|
||||
htmlDoc.doc.Find(".ui.negative.message").Text(),
|
||||
translation.NewLocale("en-US").Tr("form.alpha_dash_dot_error"),
|
||||
translation.NewLocale("en-US").Tr("form.username_error"),
|
||||
)
|
||||
|
||||
unittest.AssertNotExistsBean(t, &user_model.User{Name: invalidUsername})
|
||||
|
@ -79,9 +95,7 @@ func TestRenameReservedUsername(t *testing.T) {
|
|||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
reservedUsernames := []string{
|
||||
".",
|
||||
"..",
|
||||
".well-known",
|
||||
// ".", "..", ".well-known", // The names are not only reserved but also invalid
|
||||
"admin",
|
||||
"api",
|
||||
"assets",
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue