From 294124d129b12673109767abd331c78c71e3bf2c Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Thu, 2 Mar 2023 23:57:31 +0800 Subject: [PATCH] Close the temp file when dumping database to make the temp file can be deleted on Windows (#23249) There was no `dbDump.Close()` before, Windows doesn't like to delete opened files. --- cmd/dump.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/dump.go b/cmd/dump.go index c879d2fbe..600ec4f32 100644 --- a/cmd/dump.go +++ b/cmd/dump.go @@ -272,6 +272,7 @@ func runDump(ctx *cli.Context) error { fatal("Failed to create tmp file: %v", err) } defer func() { + _ = dbDump.Close() if err := util.Remove(dbDump.Name()); err != nil { log.Warn("Unable to remove temporary file: %s: Error: %v", dbDump.Name(), err) }