From 29e959fd009cc05fee8182929c1ee4a92a73f2a0 Mon Sep 17 00:00:00 2001 From: Jason Song Date: Tue, 18 Jul 2023 00:19:53 +0800 Subject: [PATCH] Ignore `runs-on` with expressions when warning no matched runners (#25917) Fix #25905 Co-authored-by: Giteabot --- routers/web/repo/actions/actions.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/routers/web/repo/actions/actions.go b/routers/web/repo/actions/actions.go index e1e07b5a7..d215201bc 100644 --- a/routers/web/repo/actions/actions.go +++ b/routers/web/repo/actions/actions.go @@ -7,6 +7,7 @@ import ( "bytes" "fmt" "net/http" + "strings" actions_model "code.gitea.io/gitea/models/actions" "code.gitea.io/gitea/models/db" @@ -106,6 +107,12 @@ func List(ctx *context.Context) { for _, j := range wf.Jobs { runsOnList := j.RunsOn() for _, ro := range runsOnList { + if strings.Contains(ro, "${{") { + // Skip if it contains expressions. + // The expressions could be very complex and could not be evaluated here, + // so just skip it, it's OK since it's just a tooltip message. + continue + } if !allRunnerLabels.Contains(ro) { workflow.ErrMsg = ctx.Locale.Tr("actions.runs.no_matching_runner_helper", ro) break