finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

#1419: 500 when visit a issue with issue/comments of deleted user

Browse source
This commit is contained in:
Unknwon 2015-08-15 02:48:05 +08:00
parent e4d6b5d488
commit 30b428bf0e
5 changed files with 28 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
routers/repo/issue.go
View file

@ -508,7 +508,7 @@ func ViewIssue(ctx *middleware.Context) {
}
ctx.Data["Issue"] = issue
// ctx.Data["IsIssueOwner"] = ctx.Repo.IsOwner() || (ctx.IsSigned && issue.PosterID == ctx.User.Id)
ctx.Data["IsIssueOwner"] = ctx.Repo.IsAdmin() || (ctx.IsSigned && issue.IsPoster(ctx.User.Id))
ctx.HTML(200, ISSUE_VIEW)
}
@ -685,7 +685,7 @@ func NewComment(ctx *middleware.Context, form auth.CreateCommentForm) {
}
// Check if issue owner/poster changes the status of issue.
if (ctx.Repo.IsOwner() || issue.IsPoster(ctx.User.Id)) &&
if (ctx.Repo.IsOwner() || (ctx.IsSigned && issue.IsPoster(ctx.User.Id))) &&
(form.Status == "reopen" || form.Status == "close") {
issue.Repo = ctx.Repo.Repository
if err = issue.ChangeStatus(ctx.User, form.Status == "close"); err != nil {