From 3591d9bff925f55b5bbd1edaec4dd1e352db7a85 Mon Sep 17 00:00:00 2001 From: silverwind Date: Thu, 22 Feb 2024 04:19:13 +0100 Subject: [PATCH] Don't install playwright twice (#29302) 1. `playwright/test` is already installed as part of `deps-frontend` on CI which runs before, so it's better to not install it again (on a potentially different version), and just use the version from package.json and add the `deps-frontend` dependency. 2. `PLAYWRIGHT_DIR` is a undefined variable, so I removed it ```bash $ git show c8ded77680db7344c8dc1ccee76bce0b4e02e103 | grep PLAYWRIGHT_DIR +playwright: $(PLAYWRIGHT_DIR) ``` (cherry picked from commit c236e64aca42b9ab0743431bc505033a0cb78b93) --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 194da59ef..72a48038f 100644 --- a/Makefile +++ b/Makefile @@ -625,8 +625,7 @@ test-mssql\#%: integrations.mssql.test generate-ini-mssql test-mssql-migration: migrations.mssql.test migrations.individual.mssql.test .PHONY: playwright -playwright: $(PLAYWRIGHT_DIR) - npm install --no-save @playwright/test +playwright: deps-frontend npx playwright install $(PLAYWRIGHT_FLAGS) .PHONY: test-e2e%