finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Code review UI improvements and bugfixes (#4682)

Browse source 
* Code review UI improvements

* More fixes to dark theme

* Style fix

* Fix to allow add code review comments only on review files tab

* More readability dark style fixes

* Fix commenting on deleted files. Fixes #4752

* Fix line blame getting for multiple corner cases
This commit is contained in:
Lauris BH 2018-09-17 17:59:49 +03:00 • committed by GitHub
parent 756eafaaf6
commit 4befec242a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 100 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

2
public/css/index.css
View file

File diff suppressed because one or more lines are too long

2
public/css/theme-arc-green.css
View file

File diff suppressed because one or more lines are too long

4
public/js/index.js
View file

@ -780,7 +780,7 @@ function initPullRequestReview() {
$("#show-outdated-" + id).removeClass('hide');
});
$('.comment-form-reply').on('click', function (e) {
$('button.comment-form-reply').on('click', function (e) {
e.preventDefault();
$(this).hide();
var form = $(this).parent().find('.comment-form')
@ -2649,7 +2649,7 @@ function cancelCodeComment(btn) {
var form = $(btn).closest("form");
if(form.length > 0 && form.hasClass('comment-form')) {
form.addClass('hide');
form.parent().find('.comment-form-reply').show();
form.parent().find('button.comment-form-reply').show();
}else {
console.log("Hey");
form.closest('.comment-code-cloud').remove()

29
public/less/_review.less
View file

@ -42,14 +42,21 @@
top: -13px;
}
.attached.tab {
border: none;
padding: 0;
margin: 0;
.attached
{
&.tab {
border: none;
padding: 0;
margin: 0;
&.markdown {
padding: 1em;
min-height: 168px;
&.markdown {
padding: 1em;
min-height: 168px;
}
}
&.header {
padding: .1rem 1rem;
}
}
@ -92,8 +99,12 @@
}
}
.comment-form-reply {
margin: 0.5em !important;
button.comment-form-reply {
margin: 0.5em 0.5em 0.5em 4.5em;
}
form.comment-form-reply {
margin: 0 0 0 4em;
}
}

45
public/less/themes/arc-green.less
View file

@ -181,6 +181,9 @@
background: #404552;
border: 2px solid #353945;
color: #dbdbdb;
}
.ui.accordion .title:not(.ui) {
color: #dbdbdb;
}
.ui.label {
color: #dbdbdb;
@ -195,9 +198,14 @@
.issue.list > .item {
border-bottom: 1px dashed #475767;
}
.ui.green.label, .ui.green.labels .label {
.ui.green.label, .ui.green.labels .label, .ui.basic.green.label {
background-color: #2d693b!important;
border-color: #2d693b!important;
}
.ui.basic.green.labels a.label:hover, a.ui.basic.green.label:hover {
background-color: #16ab39 !important;
border-color: #16ab39 !important;
color: #fff !important;
}
.issue.list > .item .comment {
color: #129c92;
@ -554,10 +562,17 @@
}
.ui.attached.info.message, .ui.info.message {
box-shadow: 0 0 0 1px #4b5e71 inset, 0 0 0 0 transparent;
}
.ui.positive.message {
background-color: #2c662d;
color: #fcfff5;
}
.ui.info.message {
background-color: #2c3b4a;
color: #9ebcc5;
}
.CodeMirror div.CodeMirror-cursor {
border-left: 1px solid #9e9e9e;
}
.ui .warning.header {
background-color: #5d3a22 !important;
@ -767,8 +782,34 @@
}
.repository .diff-detail-box {
background-color: inherit;
background-color: #383c4a;
.detail-files {
background-color: inherit;
}
}
.comment-code-cloud {
.ui.attached.tabular.menu {
background: none transparent;
border: none;
}
.footer .markdown-info {
color: inherit;
}
}
.file-comment {
color: #888;
}
.ui.comments .comment {
.author {
color: #dbdbdb;
}
.metadata {
color: #808084;
}
.text {
color: #9e9e9e;
}
}