finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Ensure executable bit is kept on the web editor (#10607)

Browse source 
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
This commit is contained in:
Antoine GIRARD 2020-03-05 00:46:12 +01:00 committed by GitHub
parent 3d5d21133c
commit 4e65d2b8ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/repofiles/update.go
View file

@ -230,6 +230,7 @@ func CreateOrUpdateRepoFile(repo *models.Repository, doer *models.User, opts *Up
encoding := "UTF-8" encoding := "UTF-8"
bom := false bom := false
executable := false
if !opts.IsNewFile { if !opts.IsNewFile {
fromEntry, err := commit.GetTreeEntryByPath(fromTreePath) fromEntry, err := commit.GetTreeEntryByPath(fromTreePath)
@ -265,6 +266,7 @@ func CreateOrUpdateRepoFile(repo *models.Repository, doer *models.User, opts *Up
return nil, models.ErrSHAOrCommitIDNotProvided{} return nil, models.ErrSHAOrCommitIDNotProvided{}
} }
encoding, bom = detectEncodingAndBOM(fromEntry, repo) encoding, bom = detectEncodingAndBOM(fromEntry, repo)
executable = fromEntry.IsExecutable()
} }
// For the path where this file will be created/updated, we need to make // For the path where this file will be created/updated, we need to make
@ -388,8 +390,14 @@ func CreateOrUpdateRepoFile(repo *models.Repository, doer *models.User, opts *Up
} }
// Add the object to the index // Add the object to the index
if err := t.AddObjectToIndex("100644", objectHash, treePath); err != nil { if executable {
return nil, err if err := t.AddObjectToIndex("100755", objectHash, treePath); err != nil {
return nil, err
}
} else {
if err := t.AddObjectToIndex("100644", objectHash, treePath); err != nil {
return nil, err
}
} }
// Now write the tree // Now write the tree