finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix password complexity check on registration (#8887)

Browse source 
* Fix registration password complexity

* Fix integration to use a complex password ;)
This commit is contained in:
guillep2k 2019-11-09 00:40:37 -03:00 committed by Lunny Xiao
parent 9ae4c17cb1
commit 6e1912c73a
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
integrations/signup_test.go
View file

@ -19,8 +19,8 @@ func TestSignup(t *testing.T) {
req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{ req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{
"user_name": "exampleUser", "user_name": "exampleUser",
"email": "exampleUser@example.com", "email": "exampleUser@example.com",
"password": "examplePassword", "password": "examplePassword!1",
"retype": "examplePassword", "retype": "examplePassword!1",
}) })
MakeRequest(t, req, http.StatusFound) MakeRequest(t, req, http.StatusFound)

5
routers/user/auth.go
View file

@ -1070,6 +1070,11 @@ func SignUpPost(ctx *context.Context, cpt *captcha.Captcha, form auth.RegisterFo
ctx.RenderWithErr(ctx.Tr("auth.password_too_short", setting.MinPasswordLength), tplSignUp, &form) ctx.RenderWithErr(ctx.Tr("auth.password_too_short", setting.MinPasswordLength), tplSignUp, &form)
return return
} }
if !password.IsComplexEnough(form.Password) {
ctx.Data["Err_Password"] = true
ctx.RenderWithErr(ctx.Tr("form.password_complexity"), tplSignUp, &form)
return
}
u := &models.User{ u := &models.User{
Name: form.UserName, Name: form.UserName,