finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Minor cleanup in ViewLatestWorkflowRun

Browse source 
Use `ctx.ServerError` instead of a separate `log.Error` + `ctx.Error`.
`ctx.ServerError` does essentially the same thing, but better.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
This commit is contained in:
Gergely Nagy 2024-02-13 22:51:01 +01:00
parent 2d321d27d1
commit 8075721823
No known key found for this signature in database
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
routers/web/repo/actions/view.go
View file

@ -22,7 +22,6 @@ import (
"code.gitea.io/gitea/modules/actions" "code.gitea.io/gitea/modules/actions"
"code.gitea.io/gitea/modules/base" "code.gitea.io/gitea/modules/base"
context_module "code.gitea.io/gitea/modules/context" context_module "code.gitea.io/gitea/modules/context"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/storage" "code.gitea.io/gitea/modules/storage"
"code.gitea.io/gitea/modules/timeutil" "code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/util" "code.gitea.io/gitea/modules/util"
@ -75,8 +74,7 @@ func ViewLatestWorkflowRun(ctx *context_module.Context) {
if errors.Is(err, util.ErrNotExist) { if errors.Is(err, util.ErrNotExist) {
ctx.NotFound("GetLatestRunForBranchAndWorkflow", err) ctx.NotFound("GetLatestRunForBranchAndWorkflow", err)
} else { } else {
log.Error("GetLatestRunForBranchAndWorkflow: %v", err) ctx.ServerError("GetLatestRunForBranchAndWorkflow", err)
ctx.Error(http.StatusInternalServerError, "Unable to get latest run for workflow on branch")
} }
return return
} }