finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update milestone counters when issue is deleted (#21459)

Browse source 
When actions besides "delete" are performed on issues, the milestone
counter is updated. However, since deleting issues goes through a
different code path, the associated milestone's count wasn't being
updated, resulting in inaccurate counts until another issue in the same
milestone had a non-delete action performed on it.

I verified this change fixes the inaccurate counts using a local docker
build.

Fixes #21254

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
Ashley Nelson 2022-10-22 10:08:10 -05:00 • committed by GitHub
parent 154efa59a5
commit 82ecd3b19e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 163 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
services/issue/issue.go
View file

@ -224,6 +224,11 @@ func deleteIssue(issue *issues_model.Issue) error {
return err
}
if err := issues_model.UpdateMilestoneCounters(ctx, issue.MilestoneID); err != nil {
return fmt.Errorf("error updating counters for milestone id %d: %w",
issue.MilestoneID, err)
}
if err := activities_model.DeleteIssueActions(ctx, issue.RepoID, issue.ID); err != nil {
return err
}