Implement CSS-only input toggling, refactor related forms

UX/Translation changes:

- new teams: remove redundant tooltips that don't add meaningful information
  - move general information to table fieldset
- new teams: rename "general" to "custom" access for clarity
- new teams: show labels beside options on mobile

Accessibility:

- semantic form elements allow easier navigation (fieldset, mostly)
- improve better labelling of new teams table
- fix accessibility scan issues
- TODO: the parts that "disable" form elements were not yet touched and
  are not really accessible to screenreaders

Technical:

- replace two JavaScript solutions with one CSS standard
- implement a simpler grid (.simple-grid)
- simplify markup
- remove some webhook settings specific CSS

Testing:

- check more form content for accessibility issues
- but exclude tooltips from the scan :(
- reuse existing form tests from previous PR

tests/e2e/org-settings.test.e2e.js

@@ -14,12 +14,11 @@ test('org team settings', async ({browser}, workerInfo) => {
   await expect(response?.status()).toBe(200);
 
   await page.locator('input[name="permission"][value="admin"]').click();
-  await expect(page.locator('.team-units')).toBeHidden();
-
-  // we are validating the form here, because the now hidden part has accessibility issues anyway
-  // this should be moved up or down once they are fixed.
-  await validate_form({page});
+  await expect(page.locator('.hide-unless-checked')).toBeHidden();
 
   await page.locator('input[name="permission"][value="read"]').click();
-  await expect(page.locator('.team-units')).toBeVisible();
+  await expect(page.locator('.hide-unless-checked')).toBeVisible();
+
+  // we are validating the form here to include the part that could be hidden
+  await validate_form({page});
 });

tests/e2e/repo-settings.test.e2e.js

@@ -14,16 +14,15 @@ test('repo webhook settings', async ({browser}, workerInfo) => {
   await expect(response?.status()).toBe(200);
 
   await page.locator('input[name="events"][value="choose_events"]').click();
-  await expect(page.locator('.events.fields')).toBeVisible();
+  await expect(page.locator('.hide-unless-checked')).toBeVisible();
+
+  // check accessibility including the custom events (now visible) part
+  await validate_form({page}, 'fieldset');
 
   await page.locator('input[name="events"][value="push_only"]').click();
-  await expect(page.locator('.events.fields')).toBeHidden();
+  await expect(page.locator('.hide-unless-checked')).toBeHidden();
   await page.locator('input[name="events"][value="send_everything"]').click();
-  await expect(page.locator('.events.fields')).toBeHidden();
-
-  // restrict to improved semantic HTML, the rest of the page fails the accessibility check
-  // only execute when the ugly part is hidden - would benefit from refactoring, too
-  await validate_form({page}, 'fieldset');
+  await expect(page.locator('.hide-unless-checked')).toBeHidden();
 });
 
 test('repo branch protection settings', async ({browser}, workerInfo) => {

tests/e2e/shared/forms.js

@@ -3,7 +3,11 @@ import AxeBuilder from '@axe-core/playwright';
 
 export async function validate_form({page}, scope) {
   scope ??= 'form';
-  const accessibilityScanResults = await new AxeBuilder({page}).include(scope).analyze();
+  const accessibilityScanResults = await new AxeBuilder({page})
+    .include(scope)
+    // exclude automated tooltips from accessibility scan, remove when fixed
+    .exclude('span[data-tooltip-content')
+    .analyze();
   expect(accessibilityScanResults.violations).toEqual([]);
 
   // assert CSS properties that needed to be overriden for forms (ensure they remain active)