finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ContainerRegistry - removed Basic Auth header (#19735)

Browse source 
* Removed Basic Auth header.

* Fixed test.
This commit is contained in:
KN4CK3R 2022-05-17 13:58:42 +02:00 committed by GitHub
parent 6d54799bbc
commit 9ea9206406
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
integrations/api_packages_container_test.go
View file

@ -66,10 +66,7 @@ func TestPackageContainer(t *testing.T) {
Token string `json:"token"` Token string `json:"token"`
} }
authenticate := []string{ authenticate := []string{`Bearer realm="` + setting.AppURL + `v2/token"`}
`Bearer realm="` + setting.AppURL + `v2/token"`,
`Basic`,
}
t.Run("Anonymous", func(t *testing.T) { t.Run("Anonymous", func(t *testing.T) {
defer PrintCurrentTest(t)() defer PrintCurrentTest(t)()

1
routers/api/packages/container/container.go
View file

@ -113,7 +113,6 @@ func apiErrorDefined(ctx *context.Context, err *namedError) {
func ReqContainerAccess(ctx *context.Context) { func ReqContainerAccess(ctx *context.Context) {
if ctx.Doer == nil { if ctx.Doer == nil {
ctx.Resp.Header().Add("WWW-Authenticate", `Bearer realm="`+setting.AppURL+`v2/token"`) ctx.Resp.Header().Add("WWW-Authenticate", `Bearer realm="`+setting.AppURL+`v2/token"`)
ctx.Resp.Header().Add("WWW-Authenticate", `Basic`)
apiErrorDefined(ctx, errUnauthorized) apiErrorDefined(ctx, errUnauthorized)
} }
} }