Implement external assets
This commit is contained in:
Malte Jürgens
parent
2e234300a2
commit
a61e7c7a39
22 changed files with 826 additions and 119 deletions
67
tests/e2e/release.test.e2e.js
Normal file
67
tests/e2e/release.test.e2e.js
Normal file
|
|
@ -0,0 +1,67 @@
|
|||
// @ts-check
|
||||
import {test, expect} from '@playwright/test';
|
||||
import {login_user, save_visual, load_logged_in_context} from './utils_e2e.js';
|
||||
|
||||
test.beforeAll(async ({browser}, workerInfo) => {
|
||||
await login_user(browser, workerInfo, 'user2');
|
||||
});
|
||||
|
||||
test.describe.configure({
|
||||
timeout: 30000,
|
||||
});
|
||||
|
||||
test('External Release Attachments', async ({browser, isMobile}, workerInfo) => {
|
||||
test.skip(isMobile);
|
||||
|
||||
const context = await load_logged_in_context(browser, workerInfo, 'user2');
|
||||
/** @type {import('@playwright/test').Page} */
|
||||
const page = await context.newPage();
|
||||
|
||||
// Click "New Release"
|
||||
await page.goto('/user2/repo2/releases');
|
||||
await page.click('.button.small.primary');
|
||||
|
||||
// Fill out form and create new release
|
||||
await page.fill('input[name=tag_name]', '2.0');
|
||||
await page.fill('input[name=title]', '2.0');
|
||||
await page.click('#add-external-link');
|
||||
await page.click('#add-external-link');
|
||||
await page.fill('input[name=attachment-new-name-2]', 'Test');
|
||||
await page.fill('input[name=attachment-new-exturl-2]', 'https://forgejo.org/');
|
||||
await page.click('.remove-rel-attach');
|
||||
save_visual(page);
|
||||
await page.click('.button.small.primary');
|
||||
|
||||
// Validate release page and click edit
|
||||
await expect(page.locator('.download[open] li')).toHaveCount(3);
|
||||
await expect(page.locator('.download[open] li:nth-of-type(3)')).toContainText('Test');
|
||||
await expect(page.locator('.download[open] li:nth-of-type(3) a')).toHaveAttribute('href', 'https://forgejo.org/');
|
||||
save_visual(page);
|
||||
await page.locator('.octicon-pencil').first().click();
|
||||
|
||||
// Validate edit page and edit the release
|
||||
await expect(page.locator('.attachment_edit:visible')).toHaveCount(2);
|
||||
await expect(page.locator('.attachment_edit:visible').nth(0)).toHaveValue('Test');
|
||||
await expect(page.locator('.attachment_edit:visible').nth(1)).toHaveValue('https://forgejo.org/');
|
||||
await page.locator('.attachment_edit:visible').nth(0).fill('Test2');
|
||||
await page.locator('.attachment_edit:visible').nth(1).fill('https://gitea.io/');
|
||||
await page.click('#add-external-link');
|
||||
await expect(page.locator('.attachment_edit:visible')).toHaveCount(4);
|
||||
await page.locator('.attachment_edit:visible').nth(2).fill('Test3');
|
||||
await page.locator('.attachment_edit:visible').nth(3).fill('https://gitea.com/');
|
||||
save_visual(page);
|
||||
await page.click('.button.small.primary');
|
||||
|
||||
// Validate release page and click edit
|
||||
await expect(page.locator('.download[open] li')).toHaveCount(4);
|
||||
await expect(page.locator('.download[open] li:nth-of-type(3)')).toContainText('Test2');
|
||||
await expect(page.locator('.download[open] li:nth-of-type(3) a')).toHaveAttribute('href', 'https://gitea.io/');
|
||||
await expect(page.locator('.download[open] li:nth-of-type(4)')).toContainText('Test3');
|
||||
await expect(page.locator('.download[open] li:nth-of-type(4) a')).toHaveAttribute('href', 'https://gitea.com/');
|
||||
save_visual(page);
|
||||
await page.locator('.octicon-pencil').first().click();
|
||||
|
||||
// Delete release
|
||||
await page.click('.delete-button');
|
||||
await page.click('.button.ok');
|
||||
});
|
||||
|
|
@ -347,6 +347,7 @@ func TestAPIUploadAssetRelease(t *testing.T) {
|
|||
|
||||
assert.EqualValues(t, "stream.bin", attachment.Name)
|
||||
assert.EqualValues(t, 104, attachment.Size)
|
||||
assert.EqualValues(t, "attachment", attachment.Type)
|
||||
})
|
||||
}
|
||||
|
||||
|
|
@ -385,3 +386,69 @@ func TestAPIGetReleaseArchiveDownloadCount(t *testing.T) {
|
|||
assert.Equal(t, int64(1), release.ArchiveDownloadCount.TarGz)
|
||||
assert.Equal(t, int64(0), release.ArchiveDownloadCount.Zip)
|
||||
}
|
||||
|
||||
func TestAPIExternalAssetRelease(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
||||
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
|
||||
session := loginUser(t, owner.LowerName)
|
||||
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
|
||||
|
||||
r := createNewReleaseUsingAPI(t, token, owner, repo, "release-tag", "", "Release Tag", "test")
|
||||
|
||||
req := NewRequest(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/releases/%d/assets?name=test-asset&external_url=https%%3A%%2F%%2Fforgejo.org%%2F", owner.Name, repo.Name, r.ID)).
|
||||
AddTokenAuth(token)
|
||||
resp := MakeRequest(t, req, http.StatusCreated)
|
||||
|
||||
var attachment *api.Attachment
|
||||
DecodeJSON(t, resp, &attachment)
|
||||
|
||||
assert.EqualValues(t, "test-asset", attachment.Name)
|
||||
assert.EqualValues(t, 0, attachment.Size)
|
||||
assert.EqualValues(t, "https://forgejo.org/", attachment.DownloadURL)
|
||||
assert.EqualValues(t, "external", attachment.Type)
|
||||
}
|
||||
|
||||
func TestAPIDuplicateAssetRelease(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
||||
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
|
||||
session := loginUser(t, owner.LowerName)
|
||||
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
|
||||
|
||||
r := createNewReleaseUsingAPI(t, token, owner, repo, "release-tag", "", "Release Tag", "test")
|
||||
|
||||
filename := "image.png"
|
||||
buff := generateImg()
|
||||
body := &bytes.Buffer{}
|
||||
|
||||
writer := multipart.NewWriter(body)
|
||||
part, err := writer.CreateFormFile("attachment", filename)
|
||||
assert.NoError(t, err)
|
||||
_, err = io.Copy(part, &buff)
|
||||
assert.NoError(t, err)
|
||||
err = writer.Close()
|
||||
assert.NoError(t, err)
|
||||
|
||||
req := NewRequestWithBody(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/releases/%d/assets?name=test-asset&external_url=https%%3A%%2F%%2Fforgejo.org%%2F", owner.Name, repo.Name, r.ID), body).
|
||||
AddTokenAuth(token)
|
||||
req.Header.Add("Content-Type", writer.FormDataContentType())
|
||||
MakeRequest(t, req, http.StatusBadRequest)
|
||||
}
|
||||
|
||||
func TestAPIMissingAssetRelease(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
||||
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
|
||||
session := loginUser(t, owner.LowerName)
|
||||
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
|
||||
|
||||
r := createNewReleaseUsingAPI(t, token, owner, repo, "release-tag", "", "Release Tag", "test")
|
||||
|
||||
req := NewRequest(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/releases/%d/assets?name=test-asset", owner.Name, repo.Name, r.ID)).
|
||||
AddTokenAuth(token)
|
||||
MakeRequest(t, req, http.StatusBadRequest)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -78,7 +78,7 @@ func TestMirrorPull(t *testing.T) {
|
|||
IsDraft: false,
|
||||
IsPrerelease: false,
|
||||
IsTag: true,
|
||||
}, nil, ""))
|
||||
}, "", []*release_service.AttachmentChange{}))
|
||||
|
||||
_, err = repo_model.GetMirrorByRepoID(ctx, mirror.ID)
|
||||
assert.NoError(t, err)
|
||||
|
|
|
|||
|
|
@ -111,7 +111,7 @@ func TestWebhookReleaseEvents(t *testing.T) {
|
|||
IsDraft: false,
|
||||
IsPrerelease: false,
|
||||
IsTag: false,
|
||||
}, nil, ""))
|
||||
}, "", nil))
|
||||
|
||||
// check the newly created hooktasks
|
||||
hookTasksLenBefore := len(hookTasks)
|
||||
|
|
@ -125,7 +125,7 @@ func TestWebhookReleaseEvents(t *testing.T) {
|
|||
|
||||
t.Run("UpdateRelease", func(t *testing.T) {
|
||||
rel := unittest.AssertExistsAndLoadBean(t, &repo_model.Release{RepoID: repo.ID, TagName: "v1.1.1"})
|
||||
assert.NoError(t, release.UpdateRelease(db.DefaultContext, user, gitRepo, rel, nil, nil, nil, false))
|
||||
assert.NoError(t, release.UpdateRelease(db.DefaultContext, user, gitRepo, rel, false, nil))
|
||||
|
||||
// check the newly created hooktasks
|
||||
hookTasksLenBefore := len(hookTasks)
|
||||
|
|
@ -157,7 +157,7 @@ func TestWebhookReleaseEvents(t *testing.T) {
|
|||
|
||||
t.Run("UpdateRelease", func(t *testing.T) {
|
||||
rel := unittest.AssertExistsAndLoadBean(t, &repo_model.Release{RepoID: repo.ID, TagName: "v1.1.2"})
|
||||
assert.NoError(t, release.UpdateRelease(db.DefaultContext, user, gitRepo, rel, nil, nil, nil, true))
|
||||
assert.NoError(t, release.UpdateRelease(db.DefaultContext, user, gitRepo, rel, true, nil))
|
||||
|
||||
// check the newly created hooktasks
|
||||
hookTasksLenBefore := len(hookTasks)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue