finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Upgrade golangci-lint to 1.24.0 (#10894)

Browse source 
* upgrade golangci-lint to 1.24.0 to allow go 1.14 compatibility
* fix golangci-lint errors
* make make golangci-lint work when out of go-path

Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
zeripath 2020-03-30 19:52:45 +01:00 • committed by GitHub
parent 972b3bf3b0
commit bf847b9397
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
models/error.go
View file

@ -227,7 +227,7 @@ func IsErrUserNotAllowedCreateOrg(err error) bool {
}
func (err ErrUserNotAllowedCreateOrg) Error() string {
return fmt.Sprintf("user is not allowed to create organizations")
return "user is not allowed to create organizations"
}
// ErrReachLimitOfRepo represents a "ReachLimitOfRepo" kind of error.
@ -561,7 +561,7 @@ func IsErrAccessTokenEmpty(err error) bool {
}
func (err ErrAccessTokenEmpty) Error() string {
return fmt.Sprintf("access token is empty")
return "access token is empty"
}
// ________ .__ __ .__
@ -1107,7 +1107,7 @@ func IsErrSHAOrCommitIDNotProvided(err error) bool {
}
func (err ErrSHAOrCommitIDNotProvided) Error() string {
return fmt.Sprintf("a SHA or commmit ID must be proved when updating a file")
return "a SHA or commmit ID must be proved when updating a file"
}
// __ __ ___. .__ __

2
models/notification.go
View file

@ -611,7 +611,7 @@ func (nl NotificationList) LoadIssues() ([]int, error) {
// Without returns the notification list without the failures
func (nl NotificationList) Without(failures []int) NotificationList {
if failures == nil || len(failures) == 0 {
if len(failures) == 0 {
return nl
}
remaining := make([]*Notification, 0, len(nl))