From c640a1818a975a0fb4819192a22eccb58012fbe6 Mon Sep 17 00:00:00 2001 From: silverwind <me@silverwind.io> Date: Sun, 26 Jan 2020 17:13:38 +0100 Subject: [PATCH] add explicit dimensions to navbar avatar (#9986) * add explicit dimensions to navbar avatar this prevents a temporary layout change when navigating between pages with cache disabled. * also add dimensions on frontpage Co-authored-by: Lauris BH <lauris@nix.lv> --- templates/base/head_navbar.tmpl | 2 +- templates/user/dashboard/navbar.tmpl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl index 5f1b9405d..4219e3377 100644 --- a/templates/base/head_navbar.tmpl +++ b/templates/base/head_navbar.tmpl @@ -78,7 +78,7 @@ <div class="ui dropdown jump item poping up" tabindex="-1" data-content="{{.i18n.Tr "user_profile_and_more"}}" data-variation="tiny inverted"> <span class="text"> - <img class="ui tiny avatar image" src="{{.SignedUser.RelAvatarLink}}"> + <img class="ui tiny avatar image" width="24" height="24" src="{{.SignedUser.RelAvatarLink}}"> <span class="sr-only">{{.i18n.Tr "user_profile_and_more"}}</span> <span class="mobile-only">{{.SignedUser.Name}}</span> <i class="fitted octicon octicon-triangle-down not-mobile" tabindex="-1"></i> diff --git a/templates/user/dashboard/navbar.tmpl b/templates/user/dashboard/navbar.tmpl index ed44c3537..1ebd20c8b 100644 --- a/templates/user/dashboard/navbar.tmpl +++ b/templates/user/dashboard/navbar.tmpl @@ -3,7 +3,7 @@ <div class="item"> <div class="ui floating dropdown link jump"> <span class="text"> - <img class="ui avatar image" src="{{.ContextUser.RelAvatarLink}}" title="{{.ContextUser.Name}}"> + <img class="ui avatar image" src="{{.ContextUser.RelAvatarLink}}" title="{{.ContextUser.Name}}" width="28" height="28"> {{.ContextUser.ShortName 20}} <i class="dropdown icon"></i> </span> @@ -13,12 +13,12 @@ </div> <div class="scrolling menu items"> <a class="{{if eq .ContextUser.ID .SignedUser.ID}}active selected{{end}} item" href="{{AppSubUrl}}/{{if .PageIsIssues}}issues{{else if .PageIsPulls}}pulls{{else if .PageIsMilestonesDashboard}}milestones{{end}}"> - <img class="ui avatar image" src="{{.SignedUser.RelAvatarLink}}"> + <img class="ui avatar image" src="{{.SignedUser.RelAvatarLink}}" width="28" height="28"> {{.SignedUser.Name}} </a> {{range .Orgs}} <a class="{{if eq $.ContextUser.ID .ID}}active selected{{end}} item" title="{{.Name}}" href="{{AppSubUrl}}/org/{{.Name}}/{{if $.PageIsIssues}}issues{{else if $.PageIsPulls}}pulls{{else if $.PageIsMilestonesDashboard}}milestones{{else}}dashboard{{end}}"> - <img class="ui avatar image" src="{{.RelAvatarLink}}"> + <img class="ui avatar image" src="{{.RelAvatarLink}}" width="28" height="28"> {{.ShortName 20}} </a> {{end}}