Remove unnecessary variable assignments (#17695)

* Remove unnecessary variable assignments

As title

* enable ineffassign

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

modules/gitgraph/graph_test.go

@@ -55,11 +55,10 @@ func BenchmarkParseGlyphs(b *testing.B) {
 	parser.Reset()
 	tgBytes := []byte(testglyphs)
 	tg := tgBytes
-	idx := bytes.Index(tg, []byte("\n"))
 	for i := 0; i < b.N; i++ {
 		parser.Reset()
 		tg = tgBytes
-		idx = bytes.Index(tg, []byte("\n"))
+		idx := bytes.Index(tg, []byte("\n"))
 		for idx > 0 {
 			parser.ParseGlyphs(tg[:idx])
 			tg = tg[idx+1:]

modules/nosql/manager_leveldb.go

@@ -48,13 +48,12 @@ func (m *Manager) GetLevelDB(connection string) (*leveldb.DB, error) {
 
 		return db.db, nil
 	}
-	dataDir := connection
 	uri := ToLevelDBURI(connection)
 	db = &levelDBHolder{
 		name: []string{connection, uri.String()},
 	}
 
-	dataDir = path.Join(uri.Host, uri.Path)
+	dataDir := path.Join(uri.Host, uri.Path)
 	opts := &opt.Options{}
 	for k, v := range uri.Query() {
 		switch replacer.Replace(strings.ToLower(k)) {

modules/web/middleware/binding.go

@@ -93,11 +93,9 @@ func Validate(errs binding.Errors, data map[string]interface{}, f Form, l transl
 	AssignForm(f, data)
 
 	typ := reflect.TypeOf(f)
-	val := reflect.ValueOf(f)
 
 	if typ.Kind() == reflect.Ptr {
 		typ = typ.Elem()
-		val = val.Elem()
 	}
 
 	if field, ok := typ.FieldByName(errs[0].FieldNames[0]); ok {