Replace assert.Fail with assert.FailNow (#27578)
assert.Fail() will continue to execute the code while assert.FailNow() not. I thought those uses of assert.Fail() should exit immediately. PS: perhaps it's a good idea to use [require](https://pkg.go.dev/github.com/stretchr/testify/require) somewhere because the assert package's default behavior does not exit when an error occurs, which makes it difficult to find the root error reason.
This commit is contained in:
parent
dca195e9bd
commit
dc04044716
14 changed files with 20 additions and 38 deletions
|
@ -51,7 +51,7 @@ func Test_SSHParsePublicKey(t *testing.T) {
|
|||
if err != nil {
|
||||
// Some servers do not support ecdsa format.
|
||||
if !strings.Contains(err.Error(), "line 1 too long:") {
|
||||
assert.Fail(t, "%v", err)
|
||||
assert.FailNow(t, "%v", err)
|
||||
}
|
||||
}
|
||||
assert.Equal(t, tc.keyType, keyTypeK)
|
||||
|
@ -60,7 +60,7 @@ func Test_SSHParsePublicKey(t *testing.T) {
|
|||
t.Run("SSHParseKeyNative", func(t *testing.T) {
|
||||
keyTypeK, lengthK, err := SSHNativeParsePublicKey(tc.content)
|
||||
if err != nil {
|
||||
assert.Fail(t, "%v", err)
|
||||
assert.FailNow(t, "%v", err)
|
||||
}
|
||||
assert.Equal(t, tc.keyType, keyTypeK)
|
||||
assert.EqualValues(t, tc.length, lengthK)
|
||||
|
|
|
@ -47,8 +47,7 @@ func checkForConsistency(t assert.TestingT, bean any) {
|
|||
assert.NoError(t, err)
|
||||
f := consistencyCheckMap[tb.Name]
|
||||
if f == nil {
|
||||
assert.Fail(t, "unknown bean type: %#v", bean)
|
||||
return
|
||||
assert.FailNow(t, "unknown bean type: %#v", bean)
|
||||
}
|
||||
f(t, bean)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue