From 187e10d8c9d8cd3edeb953e520ba370f2f1c73b3 Mon Sep 17 00:00:00 2001
From: Otto Richter <git@otto.splvs.net>
Date: Wed, 17 Apr 2024 19:32:18 +0200
Subject: [PATCH 1/2] Fix unlabelled button in code review

---
 options/locale/locale_en-US.ini | 1 +
 templates/repo/diff/box.tmpl    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
index 79eb86a17..c0b3ee242 100644
--- a/options/locale/locale_en-US.ini
+++ b/options/locale/locale_en-US.ini
@@ -99,6 +99,7 @@ disabled = Disabled
 locked = Locked
 
 copy = Copy
+copy_generic = Copy to clipboard
 copy_url = Copy URL
 copy_hash = Copy hash
 copy_content = Copy content
diff --git a/templates/repo/diff/box.tmpl b/templates/repo/diff/box.tmpl
index 6b343e4ee..71154f976 100644
--- a/templates/repo/diff/box.tmpl
+++ b/templates/repo/diff/box.tmpl
@@ -130,7 +130,7 @@
 								</div>
 								<span class="file tw-flex tw-items-center tw-font-mono tw-flex-1"><a class="muted file-link" title="{{if $file.IsRenamed}}{{$file.OldName}} → {{end}}{{$file.Name}}" href="#diff-{{$file.NameHash}}">{{if $file.IsRenamed}}{{$file.OldName}} → {{end}}{{$file.Name}}</a>
 									{{if .IsLFSFile}} ({{ctx.Locale.Tr "repo.stored_lfs"}}){{end}}
-									<button class="btn interact-fg tw-p-2" data-clipboard-text="{{$file.Name}}">{{svg "octicon-copy" 14}}</button>
+									<button class="btn interact-fg tw-p-2" data-clipboard-text="{{$file.Name}}" data-tooltip-content="{{ctx.Locale.Tr "copy_generic"}}" aria-label="{{ctx.Locale.Tr "copy_generic"}}">{{svg "octicon-copy" 14}}</button>
 									{{if $file.IsGenerated}}
 										<span class="ui label">{{ctx.Locale.Tr "repo.diff.generated"}}</span>
 									{{end}}

From 87d4746f5e3acb55d6469b33e96e774ad0179420 Mon Sep 17 00:00:00 2001
From: Otto Richter <git@otto.splvs.net>
Date: Wed, 17 Apr 2024 19:40:16 +0200
Subject: [PATCH 2/2] Rename button to "Finish Review"

Motivation: The meaning of the button is apparent from the visual
position and the number icon. This is not exposed to a screenreader.
Naming it to "Finish Review" helps with to provide the meaning of the
button as well as the number in the label.
---
 options/locale/locale_en-US.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
index c0b3ee242..2c6d831c8 100644
--- a/options/locale/locale_en-US.ini
+++ b/options/locale/locale_en-US.ini
@@ -2600,7 +2600,7 @@ diff.comment.add_single_comment = Add single comment
 diff.comment.add_review_comment = Add comment
 diff.comment.start_review = Start review
 diff.comment.reply = Reply
-diff.review = Review
+diff.review = Finish review
 diff.review.header = Submit review
 diff.review.placeholder = Review comment
 diff.review.comment = Comment