finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix #2431 - handle requests waiting for reply

Browse source 
According to the docs [1], the Reply method must be called for all
requests where WantReply is true. This fixes a hanging java ssh
implementation (jsch) which sets WantReply flag and waits for reply from
the server.

[1] https://godoc.org/golang.org/x/crypto/ssh#Request.Reply
This commit is contained in:
Dmitry Neverov 2016-01-18 16:52:38 +01:00
parent 7ef9a05588
commit fb99d50fa1
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
modules/ssh/ssh.go
View file

@ -91,6 +91,7 @@ func handleServerConn(keyID string, chans <-chan ssh.NewChannel) {
return return
} }
req.Reply(true, nil);
go io.Copy(input, ch) go io.Copy(input, ch)
io.Copy(ch, stdout) io.Copy(ch, stdout)
io.Copy(ch.Stderr(), stderr) io.Copy(ch.Stderr(), stderr)