From fc45a0d9bab15132e71bf09b624c5be63e439edc Mon Sep 17 00:00:00 2001 From: Earl Warren Date: Sat, 18 May 2024 18:42:54 +0200 Subject: [PATCH] cleanup(services/mailer): mark deadcode for removal There is no activities_model.Action* when sending a review comment, this is deadcode and should be removed. Or a new event should be added to differentiate it from a regular comment when evaluating templates. --- services/mailer/mail.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/mailer/mail.go b/services/mailer/mail.go index 86bd40ff2..b04925881 100644 --- a/services/mailer/mail.go +++ b/services/mailer/mail.go @@ -517,7 +517,7 @@ func actionToTemplate(issue *issues_model.Issue, actionType activities_model.Act case issues_model.ReviewTypeReject: name = "reject" default: - name = "review" + name = "review" // TODO: there is no activities_model.Action* when sending a review comment, this is deadcode and should be removed } case issues_model.CommentTypeCode: name = "code"