finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve flex list UI (#26970)

Browse source 
1. There is already `gt-ac`, so no need to introduce `flex-item-center`
2. The `flex-item-baseline` and `.flex-item-icon svg { margin-top: 1px
}` seem to be a tricky patch, they don't resolve the root problem, and
still cause misalignment in some cases.
* The root problem is: the "icon" needs to align with the sibling
"title"
    * So, make the "icon" and the "title" both have the same height 
3. `flex-text-inline` could only be used if the element is really
"inline", otherwise its `vertical-align` would make the box size change.
In most cases, `flex-text-block` is good enough.


![image](1b7acfc2-b1c7-4e9c-a983-2fa932026479)

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
wxiaoguang 2023-09-08 21:57:18 +08:00 • committed by GitHub
parent 4807f7be22
commit ffa4949eaa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 23 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

15
web_src/css/shared/flex-list.css
View file

@ -9,14 +9,6 @@
padding: 1em 0;
}
.flex-item-baseline {
align-items: baseline;
}
.flex-item-center {
align-items: center;
}
.flex-item .flex-item-leading {
display: flex;
align-items: flex-start;
@ -41,8 +33,10 @@
color: var(--color-primary) !important;
}
.flex-item .flex-item-icon svg {
margin-top: 1px;
.flex-item .flex-item-icon {
display: flex;
align-items: center;
height: 20px; /* match the default flex-item-title height */
}
.flex-item .flex-item-trailing {
@ -65,6 +59,7 @@
font-weight: var(--font-weight-semibold);
word-break: break-word;
min-width: 0;
min-height: 20px;
}
.flex-item .flex-item-title a {