Since https://github.com/go-gitea/gitea/pull/25686, a few `interface{}`
have sneaked into the codebase. Add this replacement to `make fmt` to
prevent this from happening again.
Ideally a linter would do this, but I haven't found any suitable.
(cherry picked from commit c77e8140bc2ac6521dbebfb77613dce2648bfcb8)
Conflicts:
- .gitattributes
Trivial conflict resolved by picking our choice of language
for `*.tmpl` files.
- Upstream chosen `Handlebars` as language for the templates, presumenly
because Github doesn't have an syntax highlighter for Go.
- Forgejo does have syntax highlighting support for Go templates, so use that.
(cherry picked from commit a79718522dc432e32cf322498ddf22ec570fa8fd)
(cherry picked from commit 380d847e5cdb179292c7bd1a5e3e6839fb8b31dd)
(cherry picked from commit 4126a9672d93fc33b72fb816a404056aac64dfc8)
(cherry picked from commit afde0ed82271df540348953a811a8e9db1a83343)
(cherry picked from commit 6ddaca00615340958e1aecca2c4807e39a2b1eff)
(cherry picked from commit 454b2f6b35c018cc631dd8847ae9d3243d9adc37)
(cherry picked from commit 58c10e1f93da8d8f193936eff00ebd86ecd8b78c)
(cherry picked from commit 19ec0a5536204105be78744b436a35710d8e8702)
(cherry picked from commit c3717ae4deb8acb43f861675dc44f689def544ed)
(cherry picked from commit 6c74bbe5757b290c2fe5ea13cd980a2b11fb207e)
(cherry picked from commit 9cb48db780c3592a6aa1df2770a309729eca35f6)
(cherry picked from commit 19cb774553302a7ece9d653d052b6de4c47de687)
(cherry picked from commit ac35eb83cd6f34da6079ec4ba8d00390aa56a0c0)
(cherry picked from commit 986a306d221b14891d1e5776ad3088d5636595cb)
(cherry picked from commit cd841848ee13878aeb7ddf57a4dee19cfb8d06be)
(cherry picked from commit 9fd13853df6e5151ababea773448ae92dd2fc01f)
(cherry picked from commit 4fa3942c19918a6333cc210bd247ce01ee51ccde)
(cherry picked from commit da23365e0f4224cebd4dd3c1d062c8d9d4082369)
(cherry picked from commit 72d189e4c411311155b3898e3b323e15986e2f70)
(cherry picked from commit d9f2a915c2c41c4e27e96d5fbcaccfa368178673)
(cherry picked from commit d8773a323d9f7bbc9b6f4b752efcaad112ee8423)
(cherry picked from commit aedaafe947b2f3715ba06b6c3423543310300ed3)
(cherry picked from commit f6ce73da178ea276daed94a9157c762f1f3e8642)
(cherry picked from commit f2cdb2fa66203400da9ec731734ea0a2b43b78f8)
(cherry picked from commit 810a983f4be89899f583f2f8c7c4c7d3f5196124)
(cherry picked from commit 1550d001989a8d5f2f9632f1b8de2c7cdce61657)
Move `public/*` to `public/assets/*`
Some old PRs (like #15219) introduced inconsistent directory system.
For example: why the local directory "public" is accessed by
`http://site/assets`? How to serve the ".well-known" files properly in
the public directory?
For convention rules, the "public" directory is widely used for the
website's root directory. It shouldn't be an exception for Gitea.
So, this PR makes the things consistent:
* `http://site/assets/foo` means `{CustomPath}/public/assets/foo`.
* `{CustomPath}/public/.well-known` and `{CustomPath}/public/robots.txt`
can be used in the future.
This PR is also a prerequisite for a clear solution for:
* #21942
* #25892
* discourse.gitea.io: [.well-known path serving custom files behind
proxy?](https://discourse.gitea.io/t/well-known-path-serving-custom-files-behind-proxy/5445/1)
This PR is breaking for users who have custom "public" files (CSS/JS).
After getting approvals, I will update the documents.
----
## ⚠️ BREAKING ⚠️
If you have files in your "custom/public/" folder, please move them to
"custom/public/assets/".
---------
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Giteabot <teabot@gitea.io>
They are not generated in some cases (although they can).
And we should keep an eye on these files when reviewing.
When reviewing, files can be marked as "Viewed" and then it is
collapsed.
Running it as part of the build is really unnecessary because we have a
valid output file in the repo and assuming go dependencies do not change
unless go.mod also changes, tidy really is the best target to run the
license generation after.
Also, regenerate the file as I missed to do so during the chroma update,
and mark all json files in assets as generated.
There are a few .tmpl files outside the templates directory. Match these
as well by using `*.tmpl` glob in `.gitattributes`. Also, sort the file
alphabetically.
* Remove unused Fomantic sidebar module
The [Sidebar](https://fomantic-ui.com/modules/sidebar.html) module seems
currently unused (at least I can't find any reference to it in templates
or js), so remove it from the Fomantic build.
* remove useless minified fomantic build files
* mark fomantic build files as being generated
* Update JS dependencies and misc tweaks
- Update all JS dependencies minus webpack
- Adapt CodeMirrors styling to new CSS parent introduced by EasyMDE
- Set eslint parser to latest and add new eslint 7.14 rule
- Speed up npm install by disabling audit and fund checks
- Move fomantic-ui to optional dependencies to further speed up npm
- Enable syntax highlighting on GH for .eslintrc and .stylelintrc
- Makefile cleanups
* disable audit in npmrc
* add missing dash
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Go templates are syntactically very similar to handlebars, this enabled
their syntax highlighting on GitHub.
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
These `linguist-vendored` attributes are only for the language stats
seen on github and they mostly haven't been updated with file
reorganizations. Move them to the two actually vendored directories.
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Exclude vendor dirs from git CRLF normalization
Should get rid of a few warnings like at the end of `lint-backend` like
https://drone.gitea.io/go-gitea/gitea/23117/1/4
* make vendor
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
This will ensure our repo is always checked out with LF line endings
which should help Windows users who have line ending normalization
enabled.
Additionally, added the LF preference to .editorconfig.
