finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
forgejo/routers/web/user
History
Yarden Shoham 3e8414179c
Introduce htmx and use it to avoid full page load on Subscribe and Follow (#28908) 
- Closes https://github.com/go-gitea/gitea/issues/28880

This change introduces htmx with the hope we could use it to make Gitea
more reactive while keeping our "HTML rendered on the server" approach.

- Add `htmx.js` that imports `htmx.org` and initializes error toasts
- Place `hx-headers='{"x-csrf-token": "{{.CsrfToken}}"}'` on the
`<body>` tag so every request that htmx sends is authenticated
- Place `hx-swap="outerHTML"` on the `<body>` tag so the response of
each htmx request replaces the tag it targets (as opposed to its inner
content)
- Place `hx-push-url="false"` on the `<body>` tag so no changes to the
URL happen in `<form>` tags
- Add the `is-loading` class during request

### Error toasts in action


![errors](181a1beb-1cb8-4858-abe8-fa1fc3f5b8f3)

## Don't do a full page load when clicking the subscribe button
- Refactor the form around the subscribe button into its own template
- Use htmx to perform the form submission
- `hx-boost="true"` to prevent the default form submission behavior of a
full page load
- `hx-sync="this:replace"` to replace the current request (in case the
button is clicked again before the response is returned)
  - `hx-target="this"` to replace the form tag with the new form tag
- Change the backend response to return a `<form>` tag instead of a
redirect to the issue page

### Before


![subscribe_before](cb2439a2-c3c0-425c-8d3c-5d646b1cdc28)

### After


![subscribe_after](6fcd77d8-7b11-40b0-af4f-b152aaad787c)

## Don't do a full page load when clicking the follow button
- Use htmx to perform the button request
- `hx-post="{{.ContextUser.HomeLink}}?action=follow"` to send a POST
request to follow the user
- `hx-target="#profile-avatar-card"` to target the card div for
replacement
- `hx-indicator="#profile-avatar-card"` to place the loading indicator
on the card
- Change the backend response to return a `<div>` tag (the card) instead
of a redirect to the user page

### Before


![follow_before](a210b643-6e74-4ff9-8e61-d658c62edf1f)

### After


![follow_after](5bb19ae9-0d59-4ae3-b538-4c83334e4722)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: 6543 <m.huber@kithara.com>
Co-authored-by: Giteabot <teabot@gitea.io>
2024-01-30 15:45:54 +01:00
..
setting Fix inconsistent naming of OAuth 2.0 ENABLE setting (#28951) 2024-01-28 12:36:44 +00:00
avatar.go Replace -1 with GhostUserID (#27703) 2023-10-20 14:43:08 +00:00
code.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
home.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
home_test.go Include public repos in doer's dashboard for issue search (#28304) 2023-12-07 13:26:18 +08:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
notification.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
package.go Fix some RPM registry flaws (#28782) 2024-01-19 11:37:10 +00:00
profile.go Introduce htmx and use it to avoid full page load on Subscribe and Follow (#28908) 2024-01-30 15:45:54 +01:00
search.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
stop_watch.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
task.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00