forgejo/services/repository
silverwind 6582f0029b
Add lint-go-gopls (#30729)
Uses `gopls check <files>` as a linter. Tested locally and brings up 149
errors currently for me. I don't think I want to fix them in this PR,
but I would like at least to get this analysis running on CI.

List of errors:
```
modules/indexer/code/indexer.go:181:11: impossible condition: nil != nil
routers/private/hook_post_receive.go:120:15: tautological condition: nil == nil
services/auth/source/oauth2/providers.go:185:9: tautological condition: nil == nil
services/convert/issue.go:216:11: tautological condition: non-nil != nil
tests/integration/git_test.go:332:9: impossible condition: nil != nil
services/migrations/migrate.go:179:24-43: unused parameter: ctx
services/repository/transfer.go:288:48-69: unused parameter: doer
tests/integration/api_repo_tags_test.go:75:41-61: unused parameter: session
tests/integration/git_test.go:696:64-74: unused parameter: baseBranch
tests/integration/gpg_git_test.go:265:27-39: unused parameter: t
tests/integration/gpg_git_test.go:284:23-29: unused parameter: tmpDir
tests/integration/gpg_git_test.go:284:31-35: unused parameter: name
tests/integration/gpg_git_test.go:284:37-42: unused parameter: email
```

(cherry picked from commit 816222243af523316041692622be6f48ef068693)

Conflicts:
	Makefile
	trivial context conflict and also ask renovate to watch over it
	do not include it in lint-backend because the errors are not fixed
2024-06-09 11:13:39 +02:00
..
archiver
commitstatus
files
adopt.go
adopt_test.go
avatar.go
avatar_test.go
branch.go
cache.go
check.go
collaboration.go
collaboration_test.go
commit.go
contributors_graph.go
contributors_graph_test.go
create.go
create_test.go
delete.go
fork.go
fork_test.go
generate.go cleanup(services): xstrings v1.5.0 the CAMEL & PASCAL workarounds 2024-06-07 18:10:37 +02:00
generate_test.go
hooks.go
init.go
lfs.go
lfs_test.go
main_test.go
migrate.go
push.go
repository.go
repository_test.go
review.go
review_test.go
setting.go
star.go
template.go
transfer.go Add lint-go-gopls (#30729) 2024-06-09 11:13:39 +02:00
transfer_test.go