finn/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

cleanup(services/mailer): mark deadcode for removal

Browse source 
There is no activities_model.Action* when sending a review comment,
this is deadcode and should be removed. Or a new event should be added
to differentiate it from a regular comment when evaluating templates.
This commit is contained in:
Earl Warren 2024-05-18 18:42:54 +02:00
parent 55c850a8a8
commit fc45a0d9ba
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/mailer/mail.go
View file

@ -517,7 +517,7 @@ func actionToTemplate(issue *issues_model.Issue, actionType activities_model.Act
case issues_model.ReviewTypeReject: case issues_model.ReviewTypeReject:
name = "reject" name = "reject"
default: default:
name = "review" name = "review" // TODO: there is no activities_model.Action* when sending a review comment, this is deadcode and should be removed
} }
case issues_model.CommentTypeCode: case issues_model.CommentTypeCode:
name = "code" name = "code"